Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): allow any Error returned by functions #16762

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR allows any error type returned by functions (as a simpler solution of #14159).
One of the benefit is that the openssl dependency can be removed from expr_core, speeding up the build slightly.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 enabled auto-merge May 15, 2024 14:07
Comment on lines +125 to +126
#[error("{0}")]
Function(#[source] Box<dyn std::error::Error + Send + Sync>),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also include the backtrace?

Suggested change
#[error("{0}")]
Function(#[source] Box<dyn std::error::Error + Send + Sync>),
#[error(transparent)]
Function(#[source] #[backtrace] Box<dyn std::error::Error + Send + Sync>),

@wangrunji0408 wangrunji0408 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 1cc36e1 May 20, 2024
27 of 28 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/opt-deps branch May 20, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants