Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate SinkPayloadFormat #16723

Merged
merged 11 commits into from
May 14, 2024
Merged

fix: deprecate SinkPayloadFormat #16723

merged 11 commits into from
May 14, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented May 13, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #15950
Closes #15662

The Json sink format has been deprecated and never used any more.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested review from chenzl25, wenym1 and xxhZs May 13, 2024 08:48
@github-actions github-actions bot added the type/fix Bug fix label May 13, 2024
wenym1
wenym1 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure if the SinkPayloadFormat is being used in java for some integration test. If CI passes, it's fine. If not passed, we may either remove the related CI test, or preserve the proto field and use STREAM_CHUNK anyway in the rust code.

@fuyufjh
Copy link
Member Author

fuyufjh commented May 13, 2024 •
edited
Loading

LGTM.

Not sure if the SinkPayloadFormat is being used in java for some integration test. If CI passes, it's fine. If not passed, we may either remove the related CI test, or preserve the proto field and use STREAM_CHUNK anyway in the rust code.

Thanks for reminding me. Let me try to remove the Java code & intergration tests as well.

@fuyufjh fuyufjh force-pushed the eric/issue_15662 branch from 7b2036c to a555559 Compare May 13, 2024 15:49
@fuyufjh
Copy link
Member Author

fuyufjh commented May 14, 2024 •
edited
Loading

@wenym1 I have cleaned the code in Java as well. Would you like to take a look?

As we have discussed in Slack, I disabled the test case testOnNext_writeValidation in CI pipeline. The context are recorded in the comments.

By the way, I still think it's better to use Java to decode the StreamChunk protobuf into arrays of primitive values, in order to eliminate Java-native code call overhead. Let me create an issue for it separately. #16738

wenym1
wenym1 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyufjh fuyufjh added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit ff49514 May 14, 2024
29 of 30 checks passed
@fuyufjh fuyufjh deleted the eric/issue_15662 branch May 14, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenym1 wenym1 wenym1 approved these changes

@chenzl25 chenzl25 Awaiting requested review from chenzl25

@xxhZs xxhZs Awaiting requested review from xxhZs

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connector: Deprecate JSON payload format Deprecate SinkPayloadFormat
2 participants
@fuyufjh @wenym1