-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate SinkPayloadFormat
#16723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not sure if the SinkPayloadFormat
is being used in java for some integration test. If CI passes, it's fine. If not passed, we may either remove the related CI test, or preserve the proto field and use STREAM_CHUNK
anyway in the rust code.
Thanks for reminding me. Let me try to remove the Java code & intergration tests as well. |
@wenym1 I have cleaned the code in Java as well. Would you like to take a look? As we have discussed in Slack, I disabled the test case By the way, I still think it's better to use Java to decode the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #15950
Closes #15662
The
Json
sink format has been deprecated and never used any more.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.