feat: Optimize the performance of scaling in the SQL backend. #16722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
force-pushed
the
peng/scale-sql-version
branch
from
60116d3 to
3d78569
Compare
shanicky
force-pushed
the
peng/scale-sql-version
branch
from
3d78569 to
bb0e444
Compare
shanicky
force-pushed
the
peng/scale-sql-version
branch
2 times, most recently
from
e52067b to
0dae38a
Compare
shanicky
force-pushed
the
peng/scale-sql-version
branch
from
0dae38a to
a7d6b1d
Compare
shanicky
force-pushed
the
peng/scale-sql-version
branch
3 times, most recently
from
0acc646 to
d3451bf
Compare
shanicky
force-pushed
the
peng/scale-sql-version
branch
2 times, most recently
from
c68a0cf to
ec8a750
Compare
shanicky
force-pushed
the
peng/scale-sql-version
branch
from
824889d to
a443e1b
Compare
…dates Refactor imports in scale.rs across controller & stream Signed-off-by: Shanicky Chen <[email protected]>
…ed vars in `generate_table_resize_plan`. Signed-off-by: Shanicky Chen <[email protected]>
…dd MetaMgrV2, async build_index_v2. Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/scale-sql-version
branch
from
a443e1b to
4c2f413
Compare
…`, and remove `println!` debug print.
|
It looks like it's ready for review. 🤔 |
yezizp2012
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
🎉 🎉 LGTM, thx for the job! We can add or change the madsim integration tests after #15612 .
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
Signed-off-by: Shanicky Chen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
#18092) Signed-off-by: Shanicky Chen <[email protected]> Co-authored-by: Shanicky Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR attempts to use the native Fragment/Actor structure to replace the original list_all_table_fragments during the scaling process.
Checklist
./risedev check(or alias,./risedev c)