Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(object store): ban streaming upload for azure blob storage #16715

Merged
merged 4 commits into from
May 27, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented May 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, compactor panic caused by triggering unreachable code can be temporarily avoided.

related to #16848

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label May 13, 2024
@wcy-fdu wcy-fdu requested a review from hzxa21 May 13, 2024 04:33
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented May 14, 2024

After further debugging, the memory leak is not related to streaming upload.

@wcy-fdu wcy-fdu closed this May 14, 2024
@wcy-fdu wcy-fdu reopened this May 27, 2024
@wcy-fdu wcy-fdu enabled auto-merge May 27, 2024 09:46
@wcy-fdu wcy-fdu added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit a0d7323 May 27, 2024
27 of 28 checks passed
@wcy-fdu wcy-fdu deleted the wcy/ban_azblob_streaming_upload branch May 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants