refactor(postgres-cdc): refactor postgres_row_to_owned_row #16714
Task list completed / task-list-completed
Started
2024-05-28 20:42:06
ago
4 / 8 tasks completed
4 tasks still to be completed
Details
Required Tasks
| Task | Status |
|---|---|
| I have written necessary rustdoc comments | Incomplete |
| I have added necessary unit tests and integration tests | Incomplete |
| I have added test labels as necessary. See details. | Completed |
| I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). | Incomplete |
| My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). | Completed |
All checks passed in ./risedev check (or alias, ./risedev c) |
Completed |
| My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) | Completed |
| My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) | Incomplete |
Disallow ingesting such data type at all, for example interval[] |
Incomplete |
| Spend more time on fixing debezium. IIRC there is dark magic in java class loader to replace a certain library class without forking the project | Incomplete |
from_scalar return ScalarAdapter directly, but ScalarAdapter::NumericList requires Vec<Option<PgNumeric>> actually. |
Incomplete |
If we don't handle (ScalarRefImpl::Decimal, &Type::NUMERIC), ScalarRefImpl::Decimal will be builtin. We have implement ToSql for rw's Decimal, so it acceptale by PG. If we handle (ScalarRefImpl::Decimal, &Type::NUMERIC), we have to first convert it to string and then parse as PgNumeric, seems unnecessary. |
Incomplete |
bpchar has a different semantic from varchar #1495 |
Incomplete |
When do we need name? |
Incomplete |
When does unknown appear in pgwire? I thought it was only temporary before type resolution. |
Incomplete |
Loading