Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): grant view when grant table #16699

Merged
merged 1 commit into from
May 13, 2024

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented May 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Allow grant/revoke privileges on views.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single node e2e test failed, rest LGTM:

thread 'rw-main' panicked at /risingwave/src/meta/src/controller/utils.rs:762:38:
internal error: entered unreachable code: index is not supported yet
stack backtrace:
0: rust_begin_unwind
at /rustc/e4c626dd9a17a23270bf8e7158e59cf2b9c04840/library/std/src/panicking.rs:645:5

@KeXiangWang KeXiangWang force-pushed the wkx/fix-grant-priviilege-on-all-table branch 3 times, most recently from 6b4fdbf to dce9ee9 Compare May 12, 2024 23:35
Base automatically changed from wkx/has_table_privilege to main May 13, 2024 15:45
@KeXiangWang KeXiangWang force-pushed the wkx/fix-grant-priviilege-on-all-table branch from dce9ee9 to c66f771 Compare May 13, 2024 16:12
@KeXiangWang KeXiangWang enabled auto-merge May 13, 2024 16:12
@KeXiangWang KeXiangWang added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 39075f7 May 13, 2024
29 of 31 checks passed
@KeXiangWang KeXiangWang deleted the wkx/fix-grant-priviilege-on-all-table branch May 13, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants