Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(optimizer, agg): reuse agg call rewriting logic between agg and over window #16690

Merged
merged 3 commits into from
May 12, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented May 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we have almost duplicated code in LogicalAggBuilder::try_rewrite_agg_call and LogicalOverWindowBuilder::try_rewrite_window_function, this PR merge the logic so that future updates won't miss any of the two.

This closes #11507.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc requested review from chenzl25, yuhao-su, xxchan and st1page May 10, 2024 07:41
@stdrc stdrc changed the title refactor(optimizer, agg): reuse agg call rewriting logic refactor(optimizer, agg): reuse agg call rewriting logic between agg and over window May 10, 2024
Signed-off-by: Richard Chien <[email protected]>
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stdrc stdrc added this pull request to the merge queue May 12, 2024
Merged via the queue into main with commit 7da5ea8 May 12, 2024
29 of 30 checks passed
@stdrc stdrc deleted the rc/reuse-agg-rewrite branch May 12, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract agg call rewriting logic to reuse between LogicalOverWindow and LogicalAgg
2 participants