Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pipeline auto-update Helm Charts and Operator on New Release #16642

Merged
merged 4 commits into from
May 9, 2024

Conversation

Stab123
Copy link
Contributor

@Stab123 Stab123 commented May 8, 2024

… New Release

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@Stab123 Stab123 changed the title feat: add pipeline auto-update Helm Charts and Risingwave Operator on… feat: add pipeline auto-update Helm Charts and Operator on New Release May 9, 2024
@Stab123 Stab123 requested a review from arkbriar May 9, 2024 01:59
@Stab123 Stab123 marked this pull request as ready for review May 9, 2024 02:00
sed -i "/type: application/,/version:/!b; /version:/s/version: .*/version: $NEW_VERSION/" Chart.yaml
sed -i "s/^appVersion: .*/appVersion: \"${{ github.event.release.tag_name }}\"/" Chart.yaml
echo "NEW_CHART_VERSION=$NEW_VERSION" >> $GITHUB_ENV
echo "NEW_APP_VERSION=${{ github.event.release.tag_name }}" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEW_APP_VERSION can be hoisted.

Copy link
Contributor

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stab123 Stab123 added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit d472238 May 9, 2024
12 of 13 checks passed
@Stab123 Stab123 deleted the jiawei/pipeline branch May 9, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants