Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(batch): remove unused mem code #16641

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented May 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Remove the batch mem usage dead code introduced a long time ago without any progress.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 changed the title refactor: remove unused mem code refactor(batch): remove unused mem code May 8, 2024
@chenzl25 chenzl25 requested a review from ZENOTME May 8, 2024 09:36
@chenzl25 chenzl25 requested review from xiangjinwu and xxchan May 8, 2024 09:36
@chenzl25 chenzl25 enabled auto-merge May 8, 2024 10:03
@chenzl25 chenzl25 added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 94d9e1b May 8, 2024
30 of 31 checks passed
@chenzl25 chenzl25 deleted the dylan/remove_unused_mem_code branch May 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants