feat(expr): support interval * int

[TennyZhuang]

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

As title

Checklist

• I have written necessary docs and comments
• I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#112

[codecov]

Codecov Report

Merging #1663 (47b6b1a) into main (bf74823) will decrease coverage by 0.01%.
The diff coverage is 39.47%.

@@             Coverage Diff              @@
##               main    #1663      +/-   ##
============================================
- Coverage     69.93%   69.92%   -0.02%     
  Complexity     2766     2766              
============================================
  Files          1052     1052              
  Lines         92427    92464      +37     
  Branches       1790     1790              
============================================
+ Hits          64638    64652      +14     
- Misses        26898    26921      +23     
  Partials        891      891              

Flag	Coverage Δ
java	61.01% <ø> (ø)
rust	71.76% <39.47%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/common/src/types/interval.rs	57.14% <0.00%> (-4.93%)	⬇️
src/expr/src/expr/expr_binary_nonnull.rs	77.73% <ø> (ø)
src/expr/src/vector_op/arithmetic_op.rs	72.63% <0.00%> (-5.34%)	⬇️
src/frontend/src/expr/type_inference.rs	94.17% <100.00%> (+0.21%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[neverchanje]

lgtm

[neverchanje]

I'd prefer to add build_cummulative_binary_ops to combine the two definitions.

[TennyZhuang]

Agree! I can do it in next PR, there are many other types can use this.

[xiangjinwu]

#1666/#1386

If we are going to support implicit cast, this table will be replaced completely (#1648), and repetition of cumulative ops needs to be handled in the new table.

If we decide to avoid implicit cast completely, there are a lot more improvements can be done in this builder fn.

[xiangjinwu]

lgtm. As mentioned in #1666, pg actually support int2/int4/int8/numeric/float4/float8. It can be supported either with generics or implicit cast. For now we can keep this implementation.