Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc source): fix a possible cause of cdc offset rewind #16608

Closed
wants to merge 3 commits into from
Closed

fix(cdc source): fix a possible cause of cdc offset rewind #16608

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae19b1f
emit heartbeat chunk before dtaa chunk
stdrc May 7, 2024
4544ed4
Merge branch 'main' into rc/try-fix-dbz-cdc-possible-offset-rewind
stdrc May 13, 2024
ad254e8
Merge branch 'main' into rc/try-fix-dbz-cdc-possible-offset-rewind
stdrc Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/connector/src/parser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,11 @@ async fn into_chunk_stream_inner<P: ByteStreamSourceParser>(
current_transaction = None;

if last_batch_not_yielded {
// Have to yield heartbeats before data.
if !heartbeat_builder.is_empty() {
yield heartbeat_builder.take(0);
}

yield builder.take(batch_len - (i + 1));
last_batch_not_yielded = false;
}
Expand Down
Loading