Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric): filter out NaN due to divide by zero in Grafana #16590

Merged
merged 1 commit into from
May 6, 2024

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented May 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We have many x / y pattern in the PromQL in grafana dashboard, which will show NaN noises when y == 0. This PR fixes the issue by adding > 0 or >= 0 in PromQL so that NaN will be filtered out.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 requested review from fuyufjh and MrCroxx May 6, 2024 09:23
@github-actions github-actions bot added the type/fix Bug fix label May 6, 2024
@hzxa21
Copy link
Collaborator Author

hzxa21 commented May 6, 2024

Example:

  • Prior to this PR:
    image

  • After this PR:
    image

@hzxa21 hzxa21 added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 4fea7a5 May 6, 2024
28 of 29 checks passed
@hzxa21 hzxa21 deleted the patrick/fix-grafana-nan branch May 6, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants