Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove parallel unit mapping from frontend #16588

Closed
wants to merge 20 commits into from
Closed

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented May 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

shanicky added 11 commits April 17, 2024 01:46
Refactor fragment mappings and cleanup code

Refactor worker_node, enhance vnode logic, update imports & mapping

Refactor: Disable `FragmentParallelUnitMapping` in protobuf and Rust code

Refactor/gen: Improve formatting in `risingwave_common` tests

Removed proto comments; updated Rust imports and tests.

Remove `FragmentParallelUnitMapping` import and extra lines in `observer_manager.rs`

Refactor FragManager, cleanup proto fields & comments

Remove commented-out alternative vnode placement code

Refactor: Clean up imports in fragment and streaming_job

Refactor worker mapping in join operation

Refactor fields() output in db lib for brevity

Refine comments on migration and worker ID terms
Signed-off-by: Shanicky Chen <[email protected]>
@shanicky shanicky closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant