fix(cdc): don't wait epoch commit for cdc connectors except postgres #16551
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 06e0de9 | e2e_test/source/cdc/cdc.validate.postgres.slt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| @@ -106,14 +106,9 @@ impl SourceReader { | |||
| } | |||
|
|
|||
| /// Postgres and Oracle connectors need to commit the offset to upstream. | |||
| /// And we will spawn a separate tokio task to wait for epoch commit and commit the source offset. | |||
There was a problem hiding this comment.
Didn't notice that we spawn a task. It would be better to keep the convention that an actor acts in a single-threaded manner, that is, can be concurrent but should not be parallel.
Out of the topic of this PR.
There was a problem hiding this comment.
I think you mean the compute logic of an actor? Here is pure control logic to let the actor aware the epoch commit event.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #16314
#16058 introduced a worker to wait for epoch commit before committing source offset to upstream database, but it is only required by Postgres and could be problematic for other sources. So in this PR we only apply the mechanism to Postgres.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.