Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add request.required.acks for kafka connector producer #16482

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Apr 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Requested by user.

https://kafka.apache.org/documentation/#producerconfigs_acks

This field indicates the number of acknowledgements the leader broker must receive from ISR brokers before responding to the request: 0=Broker does not send any response/ack to client, -1 or all=Broker will block until message is committed by all in sync replicas (ISRs). If there are less than min.insync.replicas (broker configuration) in the ISR set the produce request will fail.

Default value -1

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

rdkafka parameter name: request.required.acks
rw parameter name properties.request.required.acks

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su requested a review from tabVersion April 24, 2024 22:07
@yuhao-su yuhao-su changed the title feat(connector): add request.required.acks for kafka connector. feat(connector): add request.required.acks for kafka connector producer. Apr 24, 2024
@yuhao-su yuhao-su changed the title feat(connector): add request.required.acks for kafka connector producer. feat(connector): add request.required.acks for kafka connector producer Apr 24, 2024
@yuhao-su yuhao-su added user-facing-changes Contains changes that are visible to users need-cherry-pick-release-1.8 labels Apr 24, 2024
@tabVersion
Copy link
Contributor

Just to confirm what's the behavior if the producer does not receive a resp from the broker for a long time? will it report error and resend the data?

@yuhao-su
Copy link
Contributor Author

Just to confirm what's the behavior if the producer does not receive a resp from the broker for a long time? will it report error and resend the data?

It will timeout. How's that related to this pr?

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side, just adding a rdkafka property. The client will return an error when facing a timeout, subject to at least once semantic.
Please also update the doc part, specifying the default value and behavior.

@yuhao-su yuhao-su added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 4ba2e66 Apr 26, 2024
48 of 49 checks passed
@yuhao-su yuhao-su deleted the yuhao/kafka_config_acks branch April 26, 2024 16:47
github-merge-queue bot pushed a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants