-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: integrate mysql (user-managed) into risedev and inline source tests #16449
Conversation
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
query IT | ||
select * from tt1_shared; | ||
---- | ||
1 2023-10-23 10:00:00+00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, this test succeeds in CI, but failed for me locally. tt1
is ok, but tt1_shared
has a different result. Any ideas?
failed to run `e2e_test/source_inline/cdc/mysql/mysql_create_drop.slt`
Caused by:
query result mismatch:
[SQL] select * from tt1_shared;
[Diff] (-expected|+actual)
- 1 2023-10-23 10:00:00+00:00
+ 1 2023-10-23 02:00:00+00:00
at e2e_test/source_inline/cdc/mysql/mysql_create_drop.slt:177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely a bug in test setup or CDC itself, as the result is different in 8 hours when executed in different time zone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the MySqlExternalTableReader
which backfill upstream table we have executed conn.exec_drop("SET time_zone = \"+00:00\"", ()).await?;
before scan the rows. And set driver.connectionTimeZone=+00:00
in the debezium connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StrikeW Sorry that I might not understand the details yet. Do you mean this is a bug or ..?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should not happen, is it a new test case you added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try to run this test locally to see whether you can reproduce it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a simple way to run the test locally with your branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
- Add your MySQL to risedev user profile
- risedev d
- risedev slt e2e_test/source_inline/cdc/mysql/mysql_create_drop.slt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's create a separate issue for this
#16496
query IT | ||
select * from tt1_shared; | ||
---- | ||
1 2023-10-23 10:00:00+00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the MySqlExternalTableReader
which backfill upstream table we have executed conn.exec_drop("SET time_zone = \"+00:00\"", ()).await?;
before scan the rows. And set driver.connectionTimeZone=+00:00
in the debezium connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RiseDev part LGTM
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#12451
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.