-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support alter rate limit in mv, source, table with source #16399
Conversation
Bump, please leave a review. |
Just found 2 bugs. Investigating.
|
This comment was marked as outdated.
This comment was marked as outdated.
Ready for review again. |
ec0b6d0
to
300c5f5
Compare
300c5f5
to
0d1888a
Compare
############## Source from kafka (rate_limit = 0) | ||
|
||
# Wait for the topic to create | ||
skipif in-memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to skipif in-memory? 👀
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support frontend parts for altering rate limit with source, source with table, mv.
Only source, source with table now fully support for
ALTER SET STREAMING_RATE_LIMIT TO N
. Look at the slt test for more information.Changes for MV (will be done in a future PR)
For MV, this is not fully supported yet. The reason is that we need specific information to identify an MV besides its name (which alter mv provides). We need the schema, and database as well.
These parameters can be provided from the catalog in meta. Currently, when the MV is in
Creating
state, it is persisted on the meta side. However, we currently don't propagate it back to frontend, to make it "invisible" until backfill completes.We can propagate it back to frontend, and update catalog accessors to mask
Creating
catalogs.Then we can then access these
Creating
catalogs in frontend to get the necessary info to alter rate limit.In this PR, the behaviour of MV being backfilled is to reject the alter rate limit command, and inform the user that its catalog is not found.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Supports
ALTER STREAMING_RATE_LIMIT SET = default | N
for source, table with source.Example: