Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ouput_exprs from LogicalKafkaScan #16385

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan requested a review from yuhao-su April 18, 2024 11:54
@xxchan
Copy link
Member

xxchan commented Apr 18, 2024

failed to run `e2e_test/source/basic/kafka.slt`
Caused by:
    statement failed: db error: ERROR: Panicked when handling the request: a stream key is expected but not exist, plan:
    LogicalSource { source: s20, columns: [id, first_name, last_name, email] }
    This is a bug. We would appreciate a bug report at:
      https://github.com/risingwavelabs/risingwave/issues/new?labels=type%2Fbug&template=bug_report.yml
    [SQL] create table s20 (
      id integer primary key,
      first_name varchar,
      last_name varchar,
      email varchar,
      gen_id integer as id+1
    ) with (
      connector = 'kafka',
      topic = 'debezium_log',
      properties.bootstrap.server = 'message_queue:29092'
    ) FORMAT DEBEZIUM ENCODE JSON
    at e2e_test/source/basic/kafka.slt:305

@chenzl25
Copy link
Contributor Author

LGTM

I need to remove output_row_id_index from the source as well.

@chenzl25
Copy link
Contributor Author

cc @xxchan I underestimated the refactoring of source 🥵 , because it is deeply coupled with the generated columns and watermark filter. Let me change this PR just for LogicalKafkaScan

@chenzl25 chenzl25 changed the title refactor: remove ouput_exprs from source refactor: remove ouput_exprs from LogicalKafkaScan Apr 18, 2024
@xxchan xxchan self-requested a review April 18, 2024 13:07
@chenzl25 chenzl25 added this pull request to the merge queue Apr 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 19, 2024
@chenzl25 chenzl25 added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 43e8df9 Apr 19, 2024
27 of 28 checks passed
@chenzl25 chenzl25 deleted the dylan/remove_output_exprs_from_source branch April 19, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: remove output_exprs from LogicalKafkaScan
3 participants