Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(optimizer): add kafka scan operator #16371

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat(optimizer): add kafka scan operator #16371

merged 5 commits into from
Apr 18, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Apr 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Related issue: Refactor: refactor logical source for better batch optimization #16354
  • Add a LogicalKafkaScan and BatchKafkaScan to avoid coupling too much with the Source operator.
  • LogicalKafkaScan would be converted from LogiaclSource at the beginning of batch query optimization.
  • BatchKafkaScan would still be converted to SourceNode by to_batch_prost_body to keep the modification minimum.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Thanks!

Comment on lines +46 to +48
/// Expressions to output. This field presents and will be turned to a `Project` when
/// converting to a physical plan, only if there are generated columns.
output_exprs: Option<Vec<ExprImpl>>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random thought: having output_exprs here is a little sign of copy-pasting to me. Maybe we can let LogicalSource::create directly return Project + Source. (Maybe not in this PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Let's do it later. output_exprs could easily introduce a potential bug, for example, the schema of the LogicalSource could be different from its core schema which is caught by the equivalent plan checking of the optimizer during the development of this PR.

@chenzl25 chenzl25 added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 9d9d205 Apr 18, 2024
28 of 29 checks passed
@chenzl25 chenzl25 deleted the dylan/add_kafka_scan branch April 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants