-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer): add kafka scan operator #16371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Thanks!
/// Expressions to output. This field presents and will be turned to a `Project` when | ||
/// converting to a physical plan, only if there are generated columns. | ||
output_exprs: Option<Vec<ExprImpl>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random thought: having output_exprs
here is a little sign of copy-pasting to me. Maybe we can let LogicalSource::create
directly return Project + Source
. (Maybe not in this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. Let's do it later. output_exprs
could easily introduce a potential bug, for example, the schema of the LogicalSource
could be different from its core
schema which is caught by the equivalent plan checking of the optimizer during the development of this PR.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
LogicalKafkaScan
andBatchKafkaScan
to avoid coupling too much with theSource
operator.LogicalKafkaScan
would be converted fromLogiaclSource
at the beginning of batch query optimization.BatchKafkaScan
would still be converted toSourceNode
byto_batch_prost_body
to keep the modification minimum.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.