feat(error): provide service name on the client side of gRPC #16254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #13282, we introduced
ServerError
to be encoded inside the gRPC (HTTP) response and passed through the wire, so that the client could gain more information about the error occurred on the server. The most significant part is theservice_name
, so that we can know the target of the failing gRPC request.However, [
tonic::Status
] is used for both client and server side. If there's something wrong with the server side and the error is directly created on the client side, the approach above is not applicable. In this case, the caller should set a "client side" service name to provide better error message. This is what this PR is for.For example, run
FLUSH
after the meta node crashed:We're able to know there's something wrong with the meta node in the error message.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.