feat(meta,batch): support iceberg files system table #16180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzl25
force-pushed
the
dylan/support_iceberg_files_system_table
branch
from
494ffb2 to
20f2286
Compare
yezizp2012
approved these changes
Apr 8, 2024
stdrc
reviewed
Apr 8, 2024
| let source_props: HashMap<String, String> = | ||
| HashMap::from_iter(source.with_properties.clone()); | ||
| let config = ConnectorProperties::extract(source_props, false)?; | ||
| if let ConnectorProperties::Iceberg(iceberg_properties) = config { |
There was a problem hiding this comment.
Shouldn't this always go if branch?
Comment on lines
+71
to
+73
| if source.with_properties.is_iceberg_connector() { | ||
| iceberg_sources.push((schema.name.clone(), source.deref().clone())) | ||
| } |
There was a problem hiding this comment.
Nit: What about if let ConnectorProperties::Iceberg(iceberg_properties) = config { here? Seems no need to have the iceberg_sources vec.
At least iceberg_sources can be an iterator.
There was a problem hiding this comment.
We need source name and source id for the result. Let me add an unreachable!()
21 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
rw_iceberg_filesto display the current files of iceberg source/table.Example:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
rw_iceberg_filesto display the current files of iceberg source/table.Example: