Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consistency): enable state table sanity check only in strict consitency mode #16147

Merged
merged 5 commits into from
May 24, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Apr 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We have to disable state table sanity check when in non-strict consistency mode.

I've tried another approach (main...rc/mem-table-sanity), that is to still enable sanity check but ignore any error returned by mem table, however it turns out to be a bit strange, in that mem table have to do anything that is supposed to do if sanity check succeeds when it actually fails.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Apr 4, 2024
@stdrc stdrc closed this Apr 5, 2024
@stdrc stdrc force-pushed the rc/inconsistent-table branch from 138b1a7 to 35b86ae Compare April 5, 2024 05:20
@stdrc stdrc reopened this Apr 5, 2024
@stdrc stdrc marked this pull request as draft April 8, 2024 07:03
@stdrc stdrc force-pushed the rc/inconsistent-table branch from bfffd6a to ab26972 Compare April 17, 2024 07:31
@stdrc stdrc force-pushed the rc/inconsistent-table branch from 703418a to 05518a4 Compare May 20, 2024 05:19
@stdrc stdrc marked this pull request as ready for review May 20, 2024 05:22
@stdrc
Copy link
Member Author

stdrc commented May 20, 2024

Running a longevity test with unsafe_enable_strict_consistency: false: https://buildkite.com/risingwave-test/longevity-test/builds/1406

src/storage/src/store.rs Outdated Show resolved Hide resolved
@stdrc stdrc requested a review from wenym1 May 20, 2024 08:26
@stdrc
Copy link
Member Author

stdrc commented May 21, 2024

Running a longevity test with unsafe_enable_strict_consistency: false: https://buildkite.com/risingwave-test/longevity-test/builds/1406

Longevity test passed, demonstrating that user can toggle strict mode to false without significant issue.

@stdrc
Copy link
Member Author

stdrc commented May 21, 2024

The "insane" mode that help simulate inconsistent stream still has some issue, I'm still working on it to bring it to our special version of longevity test, but that is not quite related to the enable_strict_consistency toggle. We can actually publicize the config after this PR.

@stdrc stdrc requested a review from st1page May 21, 2024 08:42
@stdrc stdrc requested a review from wenym1 May 23, 2024 10:14
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/storage/src/hummock/utils.rs Outdated Show resolved Hide resolved
src/storage/src/mem_table.rs Outdated Show resolved Hide resolved
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc requested a review from wenym1 May 24, 2024 09:13
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stdrc stdrc enabled auto-merge May 24, 2024 09:19
@stdrc stdrc added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 7a16a2c May 24, 2024
27 of 28 checks passed
@stdrc stdrc deleted the rc/inconsistent-table branch May 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants