-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(consistency): enable state table sanity check only in strict consitency mode #16147
Conversation
138b1a7
to
35b86ae
Compare
bfffd6a
to
ab26972
Compare
Signed-off-by: Richard Chien <[email protected]>
703418a
to
05518a4
Compare
Running a longevity test with |
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Longevity test passed, demonstrating that user can toggle strict mode to |
The "insane" mode that help simulate inconsistent stream still has some issue, I'm still working on it to bring it to our special version of longevity test, but that is not quite related to the |
Signed-off-by: Richard Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Richard Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We have to disable state table sanity check when in non-strict consistency mode.
I've tried another approach (main...rc/mem-table-sanity), that is to still enable sanity check but ignore any error returned by mem table, however it turns out to be a bit strange, in that mem table have to do anything that is supposed to do if sanity check succeeds when it actually fails.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.