feat: improve distribution of expand and allow 2phase agg for distinct expand rewrite #16134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Apr 8, 2024
Comment on lines
-242
to
+248
| Agg::new(agg_calls, group_keys, project).with_enable_two_phase(false) | ||
| Agg::new(agg_calls, group_keys, project).with_enable_two_phase(enable_two_phase) |
There was a problem hiding this comment.
It brings performance regression in nexmark q15 before #16179
so I will turn it off back.
https://risingwave-labs.slack.com/archives/C0543LNH0KU/p1712469671285099
|
This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review. |
|
Close this PR as there's no further actions taken after it is marked as stale for 7 days. Sorry! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
revert #12185, the 2phase is worthwhile and the issue is the wrong expand derivation make the local agg after the exchange.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.