feat(sql-backend): change json column type to blob to allow proto field rename #16090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezizp2012
added
ci/run-e2e-single-node-tests
need-cherry-pick-release-1.8
ci/run-e2e-sql-migration-tests
and removed
type/feature
labels
yezizp2012
changed the title
yezizp2012
commented
Apr 2, 2024
yezizp2012
requested review from
shanicky,
xxchan,
fuyufjh,
BugenZhao and
zwang28
yezizp2012
changed the title
xxchan
reviewed
Apr 3, 2024
BugenZhao
approved these changes
Apr 3, 2024
9 tasks
fuyufjh
approved these changes
Apr 3, 2024
src/meta/model_v2/src/lib.rs
Outdated
| derive_from_json_struct!(DataType, risingwave_pb::data::DataType); | ||
| derive_from_json_struct!(DataTypeArray, Vec<risingwave_pb::data::DataType>); | ||
| derive_from_json_struct!(FieldArray, Vec<risingwave_pb::plan_common::Field>); | ||
| derive_from_byte_array!(StreamNode, PbStreamNode); |
There was a problem hiding this comment.
May add some simple comments on whether derive_from_byte_array or derive_from_json_struct should be used.
9 tasks
|
Hi is this PR blocked? |
Nope, I will get it merged today. |
yezizp2012
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #15051 .
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.