Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object store): config http client for OpenDAL s3 backend #16084

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Apr 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, we can not set

  • recv_buffer_size
  • send_buffer_size

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested a review from a team as a code owner April 2, 2024 07:31
@wcy-fdu wcy-fdu requested review from Li0k, hzxa21 and zwang28 April 2, 2024 07:33
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the PR

@wcy-fdu wcy-fdu changed the title feat(object store): config http client for OpenDAL object store feat(object store): config http client for OpenDAL s3 Apr 2, 2024
@wcy-fdu wcy-fdu changed the title feat(object store): config http client for OpenDAL s3 feat(object store): config http client for OpenDAL s3 backend Apr 2, 2024
@wcy-fdu wcy-fdu requested a review from hzxa21 April 3, 2024 01:32
@wcy-fdu wcy-fdu enabled auto-merge April 3, 2024 02:57
@wcy-fdu wcy-fdu added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit ad144ce Apr 3, 2024
27 of 28 checks passed
@wcy-fdu wcy-fdu deleted the wcy/config_http_for_opendal branch April 3, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants