Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): unblock fetch_watermarks in rdkafka (#15461) #16042

Closed
wants to merge 1 commit into from

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Apr 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Cherry-pick #15461

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Runji Wang <[email protected]>
Co-authored-by: Bohan Zhang <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx self-assigned this Apr 1, 2024
@MrCroxx MrCroxx requested a review from a team as a code owner April 1, 2024 08:23
@github-actions github-actions bot added the type/fix Bug fix label Apr 1, 2024
@MrCroxx MrCroxx deleted the branch thumbtack-hot-fix-v1.7.3 April 1, 2024 08:31
@MrCroxx MrCroxx closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants