-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink): support redis cluster url #16034
Conversation
Do you think we need to start a redis cluster for running the e2e for cluster sink? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM!
Need to add more details on the release note part.
3881de9
to
caf8d28
Compare
a0b9f57
to
cb834a0
Compare
cb834a0
to
3926983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cargo.lock
LGTM
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#15622
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
we support redis cluster url.
If redis is a cluster, we need use json array , like
redis.url= '["redis://redis-server:6379/","redis://redis-server:6380/","redis://redis-server:6381/]'
if redis is not a cluster,we need use string like (Same way as before.)
redis.url= 'redis://redis-server:6379/'