feat(object store): support azblob workload identity #15940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxa21
reviewed
Mar 27, 2024
wcy-fdu
commented
Mar 28, 2024
risedev.yml
Outdated
| @@ -343,6 +343,18 @@ profile: | |||
| - use: compute-node | |||
| - use: frontend | |||
|
|
|||
| meta-1cn-1fe-sqlite: | |||
There was a problem hiding this comment.
This change seem coming from other unrelated pr, I did not change risedev.yml and it's the same as main branch.
There was a problem hiding this comment.
Can you rebase to eliminate them from your PR?
done
hzxa21
approved these changes
Mar 28, 2024
risedev.yml
Outdated
| @@ -343,6 +343,18 @@ profile: | |||
| - use: compute-node | |||
| - use: frontend | |||
|
|
|||
| meta-1cn-1fe-sqlite: | |||
There was a problem hiding this comment.
Can you rebase to eliminate them from your PR?
done
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
…) to branch release-1.8 (#16063) Co-authored-by: wcy-fdu <[email protected]> Co-authored-by: lmatz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title, currently we use my personal fork commit for debugging, will merge this pr after reqsign release a new version.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.