Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump mimimal glibc version to 2.28 for linux binary release #15821

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Mar 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In #4556, we switched to the manylinux2014 Linux distro to ensure that the released artifact can run on systems with GLIBC versions as old as 2.17. However, this is becoming troublesome as the toolchain is also affected as described in #15749.

After some consideration and discussion with @xxchan, I think it's the time to bump the minimal GLIBC version to 2.28. Reasons:

  • Originally, Amazon Linux 2 with GLIBC 2.26 was set to reach its EOL in June 2023 but was later postponed to June 2025. However, the default image used for launching a new EC2 instance is now Amazon Linux 2023, which has GLIBC 2.34. So problems similar to feat: migration by default when recovery enabled in meta #4566 is unlikely to happen anymore.

  • The Linux binary release is not designed to use in production. For the cases that users want to play around with RisingWave (e.g. standalone mode) on their own Linux machines, I believe it's okay to assume they're on a relatively new system.

See the comments on release-env-x86 to find the updated reference of GLIBC version.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao marked this pull request as ready for review March 21, 2024 04:41
Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please run the docker build pipeline before merging.

@BugenZhao
Copy link
Member Author

LGTM! Please run the docker build pipeline before merging.

I think I need to run release.sh. How should I trigger that?

@huangjw806
Copy link
Contributor

huangjw806 commented Mar 21, 2024

I think I need to run release.sh. How should I trigger that?

Docker build pipeline will build binary(release.sh), I have triggered a build on your branch.

https://buildkite.com/risingwavelabs/docker/builds/15437

build ENV:

IMAGE_TAG=bugen-test
BINARY_NAME=bugen-test

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's arguable that whether Amazon Linux 2 should be supported. But the fact that #4556 dates back to 2022 changed my mind a little. And also the user profile of the users using released binary. (Who will play around with an old EC2?)

I still feel the motivation to change this at this timing isn't large enough. But anyway LGTM now.

@BugenZhao
Copy link
Member Author

BugenZhao commented Mar 21, 2024

buildkite.com/risingwavelabs/docker/builds/15437

The result looks good. BTW, where can I find the artifact? Didn't find it in bucket risingwave-nightly-pre-built-binary. 😕

@huangjw806
Copy link
Contributor

huangjw806 commented Mar 21, 2024

BTW, where can I find the artifact? Didn't find it in bucket risingwave-nightly-pre-built-binary.

We migrated the bucket to the new AWS account, new bucket name rw-nightly-pre-built-binary

this is the new endpoint:

http://rw-nightly-pre-built-binary.s3-website.us-east-2.amazonaws.com/

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The PR description is convincing.

@BugenZhao BugenZhao enabled auto-merge March 21, 2024 07:57
@BugenZhao BugenZhao added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 53c03b2 Mar 21, 2024
44 of 45 checks passed
@BugenZhao BugenZhao deleted the bz/deprecate-support-for-al2 branch March 21, 2024 08:51
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
xxhZs pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants