Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make --features static-link more static #15754

Merged
merged 6 commits into from
Mar 19, 2024
Merged

chore: make --features static-link more static #15754

merged 6 commits into from
Mar 19, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Mar 18, 2024

Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Further reduce the dynamic-link dependency on libz and lzma.

Under macOS:

target/debug/risingwave:
        /usr/lib/libresolv.9.dylib (compatibility version 1.0.0, current version 1.0.0)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1600.157.0)
-       /opt/homebrew/opt/xz/lib/liblzma.5.dylib (compatibility version 12.0.0, current version 12.0.0)
        /System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 61040.61.1)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1336.61.1)
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 2202.0.0)
        /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1296.60.3)
        /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit (compatibility version 1.0.0, current version 275.0.0)
-       /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.12)
        /usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)

Also pass --grouped to cargo sort to make it follow the newlines between dependencies for better organization.

Also remove build dependency on openssl-sys in workspace-hack as the dependency on sqlx has been removed since #13002.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao requested a review from xxchan March 18, 2024 10:00
@BugenZhao BugenZhao requested a review from a team as a code owner March 18, 2024 10:00
@BugenZhao BugenZhao requested a review from xxchan March 19, 2024 05:28
@BugenZhao BugenZhao enabled auto-merge March 19, 2024 05:29
@BugenZhao BugenZhao added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@BugenZhao BugenZhao added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 6bd10ab Mar 19, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/more-static branch March 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants