Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric): improve backfill metrics #15741

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel
Copy link
Contributor

kwannoel commented Mar 18, 2024

LGTM!

@chenzl25 chenzl25 enabled auto-merge March 18, 2024 09:00
@chenzl25 chenzl25 added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit af79c28 Mar 18, 2024
26 of 27 checks passed
@chenzl25 chenzl25 deleted the dylan/improve_backfill_metrics branch March 18, 2024 09:46
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
xxchan pushed a commit that referenced this pull request Mar 28, 2024
chenzl25 added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backfill metrics should be dropped after backill finishes
2 participants