fix(storage): fix race between deregister read version and clear shared buffer

[wenym1]

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolved the panic in #15703 (comment)

Currently we have an assertion that all read version must have been deregistered when calling clear shared buffer. Read version is deregistered via the drop method of LocalInstanceGuard, which sends a DestroyReadVersion event to event handler. In this way, we don't have to handle the send error when sending the newly created read version back to where made the RegisterReadVersion request.

However, in current code, the following execution flow may have remaining read version when handling clear shared buffer.

- local barrier manager receive build actor request and spawn to task to build actor
- when building actor, enqueue a `RegisterReadVersion` request to event handler channel
- local barrier manager receive a reset request, and then abort the build actor task, and then enqueue the `Clear` command to the event handler channel
- event handler handles the `RegisterReadVersion` request, and fail to send the newly created read version back to actor and return with send error.  `LocalInstanceGuard` is dropped and enqueue a `DestroyReadVersion` event to event handler.
- Since the `Clear` event is enqueued earlier than the `DestroyReadVersion` event, the event handler will handle the `Clear` event first, and then there is an existing read version and triggers the panic.

In this PR, we change to deregister the read version immediately when seeing the send error.

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• I have added test labels as necessary. See details.
• I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
• My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
• All checks passed in ./risedev check (or alias, ./risedev c)
• My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

• My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

• My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[kwannoel]

LGTM, thanks

[hzxa21]

Good catch!