Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(object_store): Continue operation in delete_objects function when… #15704

Merged
merged 6 commits into from
Apr 8, 2024
Merged

fix(object_store): Continue operation in delete_objects function when… #15704

merged 6 commits into from
Apr 8, 2024

Conversation

NiuBlibing
Copy link
Contributor

@NiuBlibing NiuBlibing commented Mar 15, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #15651
Continue deleting the remaining content in s3 when some deleting operation failed.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@NiuBlibing NiuBlibing force-pushed the fix_s3_delete_objects branch from 3f2548d to fa3d4b7 Compare March 15, 2024 08:34
@NiuBlibing NiuBlibing marked this pull request as draft March 15, 2024 08:34
@NiuBlibing NiuBlibing marked this pull request as ready for review March 15, 2024 08:35
MrCroxx
MrCroxx approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the efforts.

cc @wcy-fdu for another review.

wcy-fdu
wcy-fdu approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@NiuBlibing
Copy link
Contributor Author

@MrCroxx @wcy-fdu Hi, when will this pr be merged?

@hzxa21 hzxa21 added this pull request to the merge queue Apr 8, 2024
@hzxa21
Copy link
Collaborator

hzxa21 commented Apr 8, 2024

@MrCroxx @wcy-fdu Hi, when will this pr be merged?

Sorry for our late reply. I have added the PR to the merge queue.

Merged via the queue into risingwavelabs:main with commit 9b74f68 Apr 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcy-fdu wcy-fdu wcy-fdu approved these changes

@MrCroxx MrCroxx MrCroxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Continue operation in delete_objects function when errors occur
4 participants
@NiuBlibing @hzxa21 @MrCroxx @wcy-fdu