Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support w-tinylfu as block cache eviction algorithm #15682

Merged
merged 8 commits into from
Mar 18, 2024

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Mar 14, 2024

Signed-off-by: MrCroxx [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Refine toml config map and support w-tinylfu as block cache eviction algorithm.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx
Copy link
Contributor Author

MrCroxx commented Mar 15, 2024

All reviewers are pixel men. 🤣

image

@MrCroxx MrCroxx added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 5284975 Mar 18, 2024
27 of 28 checks passed
@MrCroxx MrCroxx deleted the xx/wtinylfu branch March 18, 2024 09:09
MrCroxx added a commit that referenced this pull request Mar 18, 2024
@zwang28
Copy link
Contributor

zwang28 commented Mar 21, 2024

@MrCroxx
After this PR, ctl sst_dump panic (because it sets some configs to 0, e.g. meta_cache_shard_num:

thread 'main' panicked at /Users/z28wang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossbeam-queue-0.3.8/src/array_queue.rs:94:9:
capacity must be non-zero
stack backtrace:
   0: std::panicking::begin_panic
             at /rustc/e4c626dd9a17a23270bf8e7158e59cf2b9c04840/library/std/src/panicking.rs:686:12
   1: crossbeam_queue::array_queue::ArrayQueue<T>::new
             at /Users/z28wang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crossbeam-queue-0.3.8/src/array_queue.rs:94:9
   2: foyer_memory::generic::GenericCache<K,V,H,E,I,L,S>::new
             at /Users/z28wang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/foyer-memory-0.1.1/src/generic.rs:402:26
   3: foyer_memory::cache::Cache<K,V,L,S>::lru
             at /Users/z28wang/.cargo/registry/src/index.crates.io-6f17d22bba15001f/foyer-memory-0.1.1/src/cache.rs:229:28
   4: risingwave_storage::hummock::sstable_store::SstableStore::new
             at ./src/storage/src/hummock/sstable_store.rs:248:57
   5: risingwave_ctl::common::hummock_service::HummockServiceOpts::create_sstable_store::{{closure}}
             at ./src/ctl/src/common/hummock_service.rs:166:21
   6: risingwave_ctl::cmd_impl::hummock::sst_dump::sst_dump::{{closure}}
             at ./src/ctl/src/cmd_impl/hummock/sst_dump.rs:112:73

@zwang28 zwang28 mentioned this pull request Mar 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants