Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): report connector name and table_id along with meta #15663

Merged
merged 8 commits into from
Mar 17, 2024

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

src/meta/src/manager/metadata.rs Outdated Show resolved Hide resolved
src/meta/src/controller/fragment.rs Outdated Show resolved Hide resolved
src/meta/src/manager/metadata.rs Outdated Show resolved Hide resolved
src/meta/src/controller/fragment.rs Outdated Show resolved Hide resolved
src/meta/src/manager/metadata.rs Outdated Show resolved Hide resolved
@tabVersion tabVersion requested a review from yezizp2012 March 13, 2024 14:07
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

src/meta/src/controller/catalog.rs Outdated Show resolved Hide resolved
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/telemetry.proto Outdated Show resolved Hide resolved
@tabVersion tabVersion enabled auto-merge March 15, 2024 09:41
@tabVersion tabVersion added this pull request to the merge queue Mar 17, 2024
Merged via the queue into main with commit 1542b88 Mar 17, 2024
28 of 29 checks passed
@tabVersion tabVersion deleted the tab/get-connector-metrics branch March 17, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants