Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink): fix redis sink parse error #15654

Merged
merged 4 commits into from
Mar 14, 2024
+9 −9
Merged

fix(sink): fix redis sink parse error #15654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6190b74
fix
xxhZs Mar 13, 2024
a42e6f3
Fix "cargo-hakari"
xxhZs Mar 13, 2024
d914b6c
Update src/connector/Cargo.toml
xxhZs Mar 14, 2024
dfc4728
Update src/risedevtool/Cargo.toml
xxhZs Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/connector/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ rdkafka = { workspace = true, features = [
"gssapi",
"zstd",
] }
redis = { version = "0.24.0", features = [
redis = { version = "0.25", features = [
"aio",
"tokio-comp",
"async-std-comp",
Expand Down
6 changes: 3 additions & 3 deletions src/connector/src/sink/redis.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use std::collections::{HashMap, HashSet};

use anyhow::anyhow;
use async_trait::async_trait;
use redis::aio::Connection;
use redis::aio::MultiplexedConnection;
use redis::{Client as RedisClient, Pipeline};
use risingwave_common::array::StreamChunk;
use risingwave_common::catalog::Schema;
Expand Down Expand Up @@ -170,14 +170,14 @@ pub struct RedisSinkWriter {

struct RedisSinkPayloadWriter {
// connection to redis, one per executor
conn: Option<Connection>,
conn: Option<MultiplexedConnection>,
// the command pipeline for write-commit
pipe: Pipeline,
}
impl RedisSinkPayloadWriter {
pub async fn new(config: RedisConfig) -> Result<Self> {
let client = config.common.build_client()?;
let conn = Some(client.get_async_connection().await?);
let conn = Some(client.get_multiplexed_async_connection().await?);
let pipe = redis::pipe();

Ok(Self { conn, pipe })
Expand Down
2 changes: 1 addition & 1 deletion src/risedevtool/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ google-cloud-pubsub = "0.23"
indicatif = "0.17"
itertools = "0.12"
rdkafka = { workspace = true }
redis = "0.24"
redis = "0.25"
regex = "1"
reqwest = "0.11"
serde = { version = "1", features = ["derive"] }
Expand Down
2 changes: 1 addition & 1 deletion src/workspace-hack/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ quote = { version = "1" }
rand = { version = "0.8", features = ["small_rng"] }
rand_chacha = { version = "0.3" }
rand_core = { version = "0.6", default-features = false, features = ["std"] }
redis = { version = "0.24", features = ["async-std-comp", "tokio-comp"] }
redis = { version = "0.25", features = ["async-std-comp", "tokio-comp"] }
regex = { version = "1" }
regex-automata = { version = "0.4", default-features = false, features = ["dfa", "hybrid", "meta", "nfa", "perf", "unicode"] }
regex-syntax = { version = "0.8" }
Expand Down
Loading