fix(batch): make batch range scan sequentially to avoid OOM #15638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
kwannoel
reviewed
Mar 12, 2024
| // WARN: DO NOT use `select` to execute range scans concurrently | ||
| // it can consume too much memory if there're too many ranges. | ||
| for range in range_scans { | ||
| let stream = Self::execute_range( |
There was a problem hiding this comment.
Not sure if it should be a default. I'm thinking a session variable can easily enable / disable this feature.
There was a problem hiding this comment.
Perhaps we can do something like:
if range_scans.len() > some_arbitrary_threshold,
then do sequential. Else do parallel.
There was a problem hiding this comment.
Make it default LGTM. Previously, point-lookup is also performed concurrently, but I changed it to sequential, because lookup-join encountered a similar issue as well.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
added a commit
that referenced
this pull request
Mar 12, 2024
…15648) Signed-off-by: Runji Wang <[email protected]> Co-authored-by: Runji Wang <[email protected]>
chenzl25
pushed a commit
that referenced
this pull request
Mar 13, 2024
Signed-off-by: Runji Wang <[email protected]>
jetjinser
pushed a commit
that referenced
this pull request
Mar 14, 2024
Signed-off-by: Runji Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #15636
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.