Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): skip docker pre-build step if the target is skipped in ENV #15579

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Mar 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Currently, if the target docker build step is skipped by ENV, the pre-build step still runs for nothing. This skips the related pre-build steps, too.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx requested review from BugenZhao and huangjw806 March 8, 2024 15:38
@MrCroxx MrCroxx self-assigned this Mar 8, 2024
@MrCroxx MrCroxx enabled auto-merge March 11, 2024 06:18
Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrCroxx MrCroxx added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit fe21213 Mar 11, 2024
39 of 40 checks passed
@MrCroxx MrCroxx deleted the xx/skip-docker-prebuild branch March 11, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants