-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): mark a test message #15548
Conversation
May I ask the motivation? Why reporting a test message? |
Then we can use the online service to validate if the report is compatible with the latest proto def. I use the field to mark if the message is from CI env and it will not be recorded into the db. |
I see. IIUC, it's supposed to be enabled only for testing telemetry, rather than enabling for all tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, it ought to only be enabled when |
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
add an
is_test
field in theReportBase
message body, marking the request is from the CI and will not be recordedrelated pr https://github.com/risingwavelabs/telemetry-backend/pull/30
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.