Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): mark a test message #15548

Merged
merged 16 commits into from
Mar 13, 2024
Merged

feat(telemetry): mark a test message #15548

merged 16 commits into from
Mar 13, 2024

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Mar 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

add an is_test field in the ReportBase message body, marking the request is from the CI and will not be recorded

related pr https://github.com/risingwavelabs/telemetry-backend/pull/30

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Base automatically changed from tab/report-in-pb to main March 8, 2024 09:38
@tabVersion tabVersion marked this pull request as ready for review March 12, 2024 08:49
@tabVersion tabVersion requested a review from a team as a code owner March 12, 2024 08:49
@fuyufjh
Copy link
Member

fuyufjh commented Mar 12, 2024

May I ask the motivation? Why reporting a test message?

@tabVersion
Copy link
Contributor Author

May I ask the motivation? Why reporting a test message?

Then we can use the online service to validate if the report is compatible with the latest proto def. I use the field to mark if the message is from CI env and it will not be recorded into the db.

@fuyufjh
Copy link
Member

fuyufjh commented Mar 13, 2024

May I ask the motivation? Why reporting a test message?

Then we can use the online service to validate if the report is compatible with the latest proto def. I use the field to mark if the message is from CI env and it will not be recorded into the db.

I see. IIUC, it's supposed to be enabled only for testing telemetry, rather than enabling for all tests.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion
Copy link
Contributor Author

May I ask the motivation? Why reporting a test message?

Then we can use the online service to validate if the report is compatible with the latest proto def. I use the field to mark if the message is from CI env and it will not be recorded into the db.

I see. IIUC, it's supposed to be enabled only for testing telemetry, rather than enabling for all tests.

Yes, it ought to only be enabled when telemetry.proto changes but requiring changing the workflow and re-compile the whole project in that case. I think running the test in every CI is a more economic way.

@tabVersion tabVersion enabled auto-merge March 13, 2024 10:03
@tabVersion tabVersion added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit e377052 Mar 13, 2024
29 of 30 checks passed
@tabVersion tabVersion deleted the tab/test-telemetry branch March 13, 2024 11:06
jetjinser pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants