Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): batch get_compact_task/apply_compact_task in once transaction #15523

Merged
merged 15 commits into from
Apr 2, 2024

do not print input sst

840b512
Select commit
Loading
Failed to load commit list.
Merged

feat(storage): batch get_compact_task/apply_compact_task in once transaction #15523

do not print input sst
840b512
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-04-02 12:14:01 ago

0 / 8 tasks completed

8 tasks still to be completed

Details

Required Tasks

Task Status
batch several get_compact_task and apply_compact_task together to reduce cost of ETCD backend. Incomplete
batch these operation so that we only need to clone once version. Incomplete
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Incomplete
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete
If the task is a Emergency task, it will be skipped if there are dynamic tasks selected in other CGs. Also, given that CG is randomized, whether there are dynamic tasks selected in other CG depends on luck. Incomplete
Otherwise, dynamic tasks in other CGs will be skipped. Incomplete
table_to_vnode_partition.clear();
Incomplete
The local variable table_to_vnode_partition is unused in this PR. Do we forget to use it in some code path? Incomplete
We won't set compact_task.table_vnode_partition if split_weight_by_vnode == 0 while prior to this PR we will set it. Is this expected? Incomplete