Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stream): remove actor_id from log and executor span #15517

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Mar 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Because span contains actor id.
similar to #14172 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from BugenZhao March 7, 2024 09:57
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me that we could also remove that from the executor spans, since the actor span already provides it. 😋

@xxchan xxchan changed the title chore(stream): remove actor_id from log chore(stream): remove actor_id from log and executor span Mar 8, 2024
@xxchan xxchan requested a review from BugenZhao March 8, 2024 03:29
@xxchan xxchan enabled auto-merge March 8, 2024 03:29
@xxchan xxchan added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@xxchan xxchan enabled auto-merge March 12, 2024 07:36
@xxchan xxchan added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 2e2a865 Mar 12, 2024
26 of 27 checks passed
@xxchan xxchan deleted the xxchan/common-partridge branch March 12, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants