Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(risedev): always download latest Kafka #15514

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Mar 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. Bumping Kafka all the time is annoying.

This should fix some of the timeout problem in main-cron test.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz enabled auto-merge March 7, 2024 09:16
@kwannoel
Copy link
Contributor

kwannoel commented Mar 7, 2024

LGTM, thanks!

@fuyufjh
Copy link
Member Author

fuyufjh commented Mar 7, 2024

It works

image

@lmatz lmatz added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit cad99ce Mar 7, 2024
26 of 28 checks passed
@lmatz lmatz deleted the eric/always_download_latest_kafka branch March 7, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants