Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): Add skip_create_new_actors to RescheduleOptions #15493

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Mar 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The offline scaling process should skip the create actor stage.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shanicky shanicky enabled auto-merge March 6, 2024 12:10
@shanicky shanicky force-pushed the peng/dont-create-actors-recovery branch from 1022998 to 753b9c2 Compare March 6, 2024 14:59
@shanicky shanicky force-pushed the peng/dont-create-actors-recovery branch from 753b9c2 to b3ecd09 Compare March 6, 2024 16:12
@shanicky shanicky added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 32c6e8c Mar 6, 2024
27 checks passed
@shanicky shanicky deleted the peng/dont-create-actors-recovery branch March 6, 2024 16:45
@kwannoel kwannoel restored the peng/dont-create-actors-recovery branch March 7, 2024 07:57
@kwannoel kwannoel deleted the peng/dont-create-actors-recovery branch March 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants