-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(udf): ensure always_retry_on_network_error
does so for all tonic errors
#15458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
changed the title
trace error
chore(ci): fix standalone tests, single node tests
Mar 5, 2024
kwannoel
force-pushed
the
kwannoel/fix-e2e
branch
from
March 5, 2024 09:10
1c14206
to
25920a4
Compare
kwannoel
changed the title
chore(ci): fix standalone tests, single node tests
fix(udf): ensure Mar 6, 2024
always_retry_on_network_error
does so for all tonic errors
kwannoel
requested review from
wangrunji0408 and
yezizp2012
and removed request for
wangrunji0408
March 6, 2024 07:45
wangrunji0408
approved these changes
Mar 6, 2024
yezizp2012
approved these changes
Mar 6, 2024
This was referenced Mar 6, 2024
This was referenced Mar 7, 2024
lmatz
pushed a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Otherwise some errors like
broken pipe error
, which also occurs when connection is closed...:...Are not caught, since the status is
Unknown
.Note that this also means the UDF server must be infalliable. Otherwise it will be stuck with this error and cannot proceed.
We have some other minor fix to leave out background ddl test fromsingle_node
mode as its flaky, since this was originally a PR intended to fix all e2e tests.And also modify the e2e test runtime.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.