Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udf): ensure always_retry_on_network_error does so for all tonic errors #15458

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Mar 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Otherwise some errors like broken pipe error, which also occurs when connection is closed...:

2024-03-06T06:51:52.297648467Z ERROR   rw-streaming risingwave_udf::external: UDF error. exiting... error=failed to send requests to UDF service: status: Unknown, message: "transport error", details: [], metadata: MetadataMap { headers: {} }: transport error: connection error: stream closed because of a broken pipe

...Are not caught, since the status is Unknown.

Note that this also means the UDF server must be infalliable. Otherwise it will be stuck with this error and cannot proceed.

We have some other minor fix to leave out background ddl test from single_node mode as its flaky, since this was originally a PR intended to fix all e2e tests.

And also modify the e2e test runtime.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel changed the title chore(ci): fix standalone tests, single node tests fix(udf): ensure always_retry_on_network_error does so for all tonic errors Mar 6, 2024
@github-actions github-actions bot added type/fix Bug fix and removed type/chore labels Mar 6, 2024
@kwannoel kwannoel requested review from wangrunji0408 and yezizp2012 and removed request for wangrunji0408 March 6, 2024 07:45
@kwannoel kwannoel marked this pull request as ready for review March 6, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants