-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: execute auto-scaling in batches #15420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
changed the title
feat: Automatic scaling supports step expansion.
feat: execute auto-scaling in batches
Mar 4, 2024
shanicky
force-pushed
the
peng/step-scale
branch
from
March 4, 2024 15:20
2d320c5
to
82c61a2
Compare
yezizp2012
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset LGTM, This PR is to solve the problem that the memory overhead during barrier mutation decode in the auto scaling process may cause cn OOM. See details in #14533 , I'm rising a PR to fix it right now.
shanicky
added a commit
that referenced
this pull request
Mar 7, 2024
shanicky
added a commit
that referenced
this pull request
Mar 7, 2024
Signed-off-by: Shanicky Chen <[email protected]>
shanicky
added a commit
that referenced
this pull request
Mar 8, 2024
shanicky
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds 3 parameters for fine-tuning the monitor loop once auto-scaling is enabled.
The
parallelism_control_batch_size
parameter is used to determine how many streaming jobs are processed each time auto-scaling is enabled. When set to 0, it will be configured to handle all jobs.The
parallelism_control_trigger_period_sec
parameter determines the period for triggering auto-scaling, with the default set to every 10 seconds.The
parallelism_control_trigger_first_delay_sec
parameter is used to determine the delay before the first scale-out to avoid unnecessary conflicts with recovery. It will be deprecated after the stream manager and barrier manager are merged.Checklist
./risedev check
(or alias,./risedev c
)