Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use system linker in macOS #15407

Closed
wants to merge 1 commit into from
Closed

chore: use system linker in macOS #15407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,12 @@ rustflags = [

[target.x86_64-apple-darwin]
rustflags = [
"-Ctarget-feature=+sse4.2", # use a generally available feature, since it's not for production
"-Clink-arg=-fuse-ld=/usr/local/opt/llvm/bin/ld64.lld",
"-Ctarget-feature=+sse4.2", # use a generally available feature, since it's not for production
]

[target.aarch64-apple-darwin]
rustflags = [
# neon is enabled by default
"-Clink-arg=-fuse-ld=/opt/homebrew/opt/llvm/bin/ld64.lld",
]

# Flags for all targets.
Expand Down
4 changes: 2 additions & 2 deletions docs/developer-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ RiseDev is the development mode of RisingWave. To develop RisingWave, you need t
To install the dependencies on macOS, run:

```shell
brew install postgresql cmake protobuf tmux cyrus-sasl llvm
brew install postgresql cmake protobuf tmux cyrus-sasl
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
```

Expand Down Expand Up @@ -566,4 +566,4 @@ Instructions about submitting PRs are included in the [contribution guidelines](
These correspond to its `depends` field in `pull-request.yml` and `main-cron.yml` .
2. Add `ci/run-e2e-test` to run the step as well.
3. Add `ci/run-main-cron` to run `main-cron` workflow in your pull request,
4. Add `ci/main-cron/skip-ci` to skip all other steps which were not selected with `ci/run-xxx`.
4. Add `ci/main-cron/skip-ci` to skip all other steps which were not selected with `ci/run-xxx`.
Loading