Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor the cycle check for sink into table. #15390

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

shanicky
Copy link
Contributor

@shanicky shanicky commented Mar 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

create table a(v int primary key); 
create table b(v int primary key); 
create sink s1 into b as select v from a;
create sink s2 into a as select v from b; 
--
ERROR:  Failed to run the query

Caused by:
  Bind error: Creating such a sink will result in circular dependency, path = [a, s1, b, s2, a]

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanicky shanicky enabled auto-merge March 4, 2024 05:37
@shanicky shanicky added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit e2149b6 Mar 4, 2024
38 of 39 checks passed
@shanicky shanicky deleted the peng/more-refine-cycle-check branch March 4, 2024 06:30
shanicky added a commit that referenced this pull request Mar 5, 2024
shanicky added a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants