Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use patched version of aws-sdk-ec2 #15379

Merged
merged 1 commit into from
Mar 4, 2024
Merged

build: use patched version of aws-sdk-ec2 #15379

merged 1 commit into from
Mar 4, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Mar 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

alternative solution to replace #15368, without introducing feature flag.

The main motivation is to make the dependency aws-sdk-ec2 optional.
It is very rarely used in development, but contributes to more than half of the compile time.

Check https://github.com/risingwavelabs/rw-aws-sdk-ec2/commits/main/ to see what's changed.

Before (4m 41.2s total)

image

After (4m 17.6s total)

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from a team as a code owner March 1, 2024 09:02
@xxchan xxchan requested review from StrikeW and BugenZhao March 1, 2024 09:02
@xxchan xxchan mentioned this pull request Mar 1, 2024
9 tasks
@tabVersion
Copy link
Contributor

this approach seems more adorable

Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach LGTM. But the reduction of overall compilation time seems not much (24 secs).

@xxchan
Copy link
Member Author

xxchan commented Mar 4, 2024

But the reduction of overall compilation time seems not much (24 secs).

This might be because of the suboptimal build graph. Previously aws-sdk-ec2 is a major blocker, but after removing it, another blocker comes. Optimizing it can make it possible to further optimize in the future. (Maybe also help save energy...)

@xxchan
Copy link
Member Author

xxchan commented Mar 4, 2024

Just tested release build. 14m53s -> 13m22s, 91s less! (aws-sdk-ec2 compiles 402.0s alone...)

@xxchan xxchan added this pull request to the merge queue Mar 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2024
@xxchan xxchan added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit ee9a13a Mar 4, 2024
37 of 38 checks passed
@xxchan xxchan deleted the xxchan/aws-sdk-ec2 branch March 4, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants