Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(udf): introduce #[derive(StructType)] for struct types in Rust UDF #15372

Merged
merged 9 commits into from
Mar 14, 2024

Merge remote-tracking branch 'origin/main' into wrj/rust-udf-0.2

869421b
Select commit
Loading
Failed to load commit list.
Merged

feat(udf): introduce #[derive(StructType)] for struct types in Rust UDF #15372

Merge remote-tracking branch 'origin/main' into wrj/rust-udf-0.2
869421b
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-03-14 10:29:56 ago

4 / 8 tasks completed

4 tasks still to be completed

Details

Required Tasks

Task Status
I have written necessary rustdoc comments Completed
I have added necessary unit tests and integration tests Completed
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Completed
For non-struct return types, I suppose there should be no change on both syntax and implementation. Incomplete
For struct return types, can we identify these cases based on an unrecognized return type of the function (other than well-known types like i32 or bool)? Incomplete
if the return type is a struct, they have to write #[function] by themselves. Incomplete
otherwise, we add it for them. Incomplete